Add CMake support for RHash #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
4 tasks
|
I have issues cross compiling static stuff, this might help This should be merged, if we believe in true justice ... |
jschueller
reviewed
Aug 30, 2023
CMakeLists.txt
Outdated
|
|
||
| option(USE_GETTEXT "Enable gettext (localization) support") | ||
|
|
||
| set(SOURCE_FILES "${CMAKE_CURRENT_SOURCE_DIR}/calc_sums.c" |
There was a problem hiding this comment.
no need for CMAKE_CURRENT_SOURCE_DIR, files are always relative to the source dir
jschueller
reviewed
Aug 30, 2023
librhash/CMakeLists.txt
Outdated
| option(USE_OPENSSL "Enable OpenSSL (optimized hash functions) support") | ||
| option(OPENSSL_RUNTIME "Load OpenSSL at runtime if present") | ||
|
|
||
| set(SOURCE_FILES "${CMAKE_CURRENT_SOURCE_DIR}/algorithms.c" |
jschueller
reviewed
Aug 30, 2023
librhash/CMakeLists.txt
Outdated
| install(TARGETS ${PROJECT_NAME} | ||
| EXPORT ${CMAKE_PROJECT_NAME}Config | ||
| RUNTIME DESTINATION bin | ||
| LIBRARY DESTINATION lib |
There was a problem hiding this comment.
if you use gnuinstalldirs then you can use CMAKE_INSTALL_LIBDIR/BINDIR/INCLUDEDIR
jschueller
reviewed
Aug 30, 2023
librhash/CMakeLists.txt
Outdated
|
|
||
| include(GNUInstallDirs) | ||
|
|
||
| if(MSVC OR MSVC90 OR MSVC10) |
jschueller
reviewed
Aug 30, 2023
librhash/CMakeLists.txt
Outdated
| include(GNUInstallDirs) | ||
|
|
||
| if(MSVC OR MSVC90 OR MSVC10) | ||
| set(MSVC ON) |
Signed-off-by: Uilian Ries <[email protected]>
valgur
added a commit
to valgur/conan-center-index
that referenced
this pull request
Nov 6, 2023
The build scripts in the project are quite non-standard and not too portable. Based on rhash/RHash#103
valgur
added a commit
to valgur/conan-center-index
that referenced
this pull request
Jan 19, 2024
The build scripts in the project are quite non-standard and not too portable. Based on rhash/RHash#103
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR brings two CMake files which can build the library and executable.
I see you are running semaphore to build this project, but I can't update it locally, so you can update your script with:
Regards!