fix: when normalizing a movie title, do not replace the letter й
#8173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database Migration
NO
Description
when normalizing a movie title, do not replace the Cyrillic letter
йRadarr uses normalization to search and compare movie titles: all diacritical letters are replaced with normal letters. But for the Cyrillic letter "й", the replacement for "и" is incorrect, because it turns out different words, and most trackers in Cyrillic do not understand such a replacement.
Example
film
Гуляй, Вася!(2017)https://www.themoviedb.org/movie/430263
search string after normalization:
Гуляи Вася 2017movie not found:
rutracker.org
0day.kiev.ua
but finds with the letter
й:rutracker.org
0day.kiev.ua
it is necessary to leave the letter
йbecause the combination letter + combinable unicode diacritic also does not find the movie, an example forГуляй Вася 2017, whereй = и + \u0306:rutracker.org
0day.kiev.ua