Fixed: Multisubs wrongly detected as hardcoded #10024
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Area: Parser
namakeingo
changed the title
As flagged by multiple people before "Multisubs" is a commonly used Tag that indicates that the file has more than 3 subtitle languages. Multisubs never indicate a hardcoded sub as you cannot have a multisubs where you can select between different languages if the subtitles are hardcoded in the video. This minor change excludes "MULTISUBS" from the regex used.
namakeingo
force-pushed
the
fix-bug-multisubs-wrongly-detected-as-hardcoded
branch
from
eace008
to
528ff60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As flagged by multiple people before "Multisubs" (same as Multisub) is a commonly used Tag (common enough that 1337x has the maximum number of pages brought back searching multisubs for example) that indicates that the file has more than 3 subtitle languages. Multisubs never indicate a hardcoded sub as you cannot have a multisubs where you can select between different languages if the subtitles are hardcoded in video. This minor change excludes "MULTISUBS" from the regex used.
Database Migration
NO
Description
"MULTISUBS" should not be identified as Hardcoded Subs
Todos
- [ ] Translation Keys (./src/NzbDrone.Core/Localization/Core/en.json)not applicable- [ ] Wiki Updatesnot applicableIssues Fixed or Closed by this PR
There are no open issues, but there are issues closed with workarounds using "Settings -> Indexers -> Whitelisted Subtitle Tags"
#3092
#1974
Also, #1208 is related although it was a feature request for the "Allow Hardcoded Subs" toggle
Additional Notes
"MSUBS" (as seen in #3092) is also a possible shortened version of MULTISUBS. I did not currently exclude it in the regex as it sounds too generic and less common than the unshortened version. If you disagree I can exclude 'MSUBS' too as part of this PR