Fixed: (Myanonamouse) Allow aborting download if FL token purchase fails

[kshannoninnes]

Database Migration

NO

Description

Updating the MAM indexer to allow for multiple freeleech token options; Never, Preferred, Required. Never should never spend any tokens, Preferred should attempt to buy and spend tokens but still download if it fails, and Required should abort the download if buying a token fails. The current behaviour is a binary choice between Never and Preferred.

This is not ready for merging yet, as I have multiple user facing issues. Here's a list of them, I would like some input:

• Is there a better way to abort non-fl downloads other than throwing ReleaseUnavailableException? I could return null and refactor everything that calls the indexer to check for it, or I could return an HTTP error status. I personally consider null returns dirty, and leads to other problems, such as not being descriptive of what actually went wrong. Returning an HTTP status feels out of scope for an indexer, but I'm a little more on the fence here.
• Is there a better way to check for something already being freeleech, other than just reading the response string after attempting to spend a token? MAM api docs are extremely bare bones and don't even list the current method of spending a token through the url queries.
• Should manually downloading a release bypass this setting and just force the download regardless of freeleech status? If it did that I could see users having issues not realizing they're manually downloading non-freeleech. If manual downloads are blocked as well, how would I go about providing a proper error message when hovering over the red icon when a download fails, per the screenshot below?

On an unrelated note, are there any servarr code style guidelines that I can read or just follow stylecop in the IDE?

Screenshot (if UI related)

Todos

• Tests
• Translation Keys (./src/NzbDrone.Core/Localization/Core/en.json)
• Wiki Updates

Issues Fixed or Closed by this PR

• Partially resolved Option to prevent downloading without FreeLeech Token #1839

[mynameisbogdan]

Now I see what you mean with ReleaseUnavailableException, I'll have to look into it later.

[mynameisbogdan]

Why don't we check the error message?

[kshannoninnes]

That's the main way I'm considering doing it, but I usually want to avoid comparing strings in error scenarios, since strings can change on a dime. If there's no better alternatives, it's what I'll roll with, but was hoping someone had a better idea (like maybe knew a way to check FL status via url query strings)

[mynameisbogdan]

Prowlarr/src/NzbDrone.Core/Indexers/Definitions/Orpheus.cs

Lines 95 to 98 in add2988

	if (html.Contains("You do not have any freeleech tokens left.")
	|| html.Contains("You do not have enough freeleech tokens")
	|| html.Contains("This torrent is too large.")
	|| html.Contains("You cannot use tokens here"))