Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show QR code #94

Open
ghost opened this issue Dec 17, 2015 · 17 comments
Open

Show QR code #94

ghost opened this issue Dec 17, 2015 · 17 comments

Comments

@ghost
Copy link

ghost commented Dec 17, 2015

Show a QR code for the different links so that mobile devices can become peers without users having to type in the URL.

@joshterrill
Copy link
Contributor

I can give this a go if it's wanted.

@ghost
Copy link
Author

ghost commented Dec 31, 2015

I only use instant.io occasionally, so don't feel obliged to do this for my sake. I do think that this feature would be very handy though.

@feross
Copy link
Member

feross commented Jan 1, 2016

@joshterrill Yeah, that would be cool to try. But are there any good QR reading libraries in pure javascript? I've seen tons of QR code generators, but only a few that can take grainy images from a webcam and parse the QR codes out of them.

@joshterrill
Copy link
Contributor

I'll look around and post what I find before I really start digging into it.

@xxxorg
Copy link

xxxorg commented Mar 2, 2016

@feross I found just https://github.com/LazarSoft/jsqrcode, do you know any other qr reading in js?

@xxxorg
Copy link

xxxorg commented Mar 2, 2016

Would you accept PR just for the qr code generation (not the reading)?

@joshterrill
Copy link
Contributor

@xxxorg I don't think we need it to read... I think it's just QR code generation so that a mobile app who has a reader can scan it. Am I right?

@feross
Copy link
Member

feross commented Mar 12, 2016

I would accept a PR just for generation for now. We can figure out reading
later.

On Fri, 11 Mar 2016 at 15:18 Joshua Terrill [email protected]
wrote:

@xxxorg https://github.com/xxxorg I don't think we need it to read... I
think it's just QR code generation so that a mobile app who has a reader
can scan it. Am I right?


Reply to this email directly or view it on GitHub
https://github.com/feross/instant.io/issues/94#issuecomment-195599483.

@nodiscc
Copy link

nodiscc commented Mar 12, 2016

I can recommend http://neocotic.com/qr.js/ for QR generation which I have been using for years in a web application.

@joshterrill
Copy link
Contributor

I just wrote this yesterday but forgot to commit it. I'll do it later today.

@rugk
Copy link

rugk commented Aug 27, 2016

As for qrcode generation there is also https://larsjung.de/kjua/. It works without jQuery and is very powerful. (alternatively this works with jQuery)

@aswinmohanme
Copy link

aswinmohanme commented Jun 15, 2018

@feross can you look into this ?

I know a dev like you would be pretty busy, but this feature would solve the issue of sharying a file with a phone easy peasy.

@joshterrill
Copy link
Contributor

joshterrill commented Jul 4, 2018

I apologize for letting this just stay open like this. I've been pretty swamped at work. If the suggestion @rugk has looks good to everyone I can try to implement it over the 4th of July break this week. @feross since that is a different library and the other pull request is pretty old, should we close the other one out and start a new one? Or should I pull the existing one down and edit it?

@joshterrill
Copy link
Contributor

@feross I just finished writing the code... not sure how you want me to go about pushing it though. Should I pull down my other PR and modify that? Or use a new one since I'm using a different library than before?

@joshterrill
Copy link
Contributor

There were enough differences in the existing code base and what was in that old PR that I figured I could just create a new PR. If this isn't what you want to do, just let me know. I've created #176 using the library @rugk suggested.

@ThelloD
Copy link

ThelloD commented Nov 29, 2020

Any update regarding the implementation status of QR codes? Feature request was created 5 years ago and pull request 1.5 years ago, so it's a bit sad that this wasn't added, yet.

@pojntfx
Copy link

pojntfx commented Dec 3, 2020

I would also really appreciate this feature. https://webwormhole.io/ is fantastic in terms of this; if one wants to, for example, transfer a file from their desktop to their phone, this would be greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants