Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Completed torrents pane includes torrents that are seeding? #20851

Open
janusn opened this issue May 15, 2024 · 9 comments
Open

The Completed torrents pane includes torrents that are seeding? #20851

janusn opened this issue May 15, 2024 · 9 comments

Comments

@janusn
Copy link

janusn commented May 15, 2024

qBittorrent & operating system versions

qBittorent: v4.6.4 Web UI (64-bit)
Operation system: Synology DSM 7.2-64570 Update 3
Qt: 6.6.3
Libtorrent: | 2.0.10.0
Docker version 20.10.23, build 876964a
Docker Image: lscr.io/linuxserver/qbittorrent:4.6.4-r1-ls329

What is the problem?

The completed pane shows the same torrents as Seeding as shown in the image below.
Screenshot 2024-05-15 at 20 55 02

Steps to reproduce

  1. Open the qBittorrent URL in a web browser.
  2. Note the number and content of Completed and Seeding torrents.

Additional context

No response

Log(s) & preferences file(s)

No response

@HanabishiRecca
Copy link
Contributor

This is intentional. Because seeding torrents are completed.

@janusn
Copy link
Author

janusn commented May 16, 2024

I don’t really get it. Seeding and Completed are listed as 2 statuses and they carry different icons. It is pretty inconsistent with other statuses.

@HanabishiRecca
Copy link
Contributor

What exactly you didn't get? Those are two different statuses.
All seeding are completed, but not all completed are seeding. You could have paused completed for example.

@glassez
Copy link
Member

glassez commented May 16, 2024

What exactly you didn't get? Those are two different statuses. All seeding are completed, but not all completed are seeding. You could have paused completed for example.

It seems that "completed" just means "completed downloading".

@janusn
Copy link
Author

janusn commented May 16, 2024

As I thought seeding means those torrents are seeding in progress and completed means the torrents have met the completed criteria and stopped. A torrent cannot not be both seeding (running) and completed (stopped) at the same time.

the screenshot I posted earlier clearly showed these torrents were seeding not completed. Nonetheless, they were shown in the completed pane. Clicking the seeding pane showed the same seeding torrents again.

So is state “completed” the same as “completed” for these 2 panes? Or should they be shown independently?

@HanabishiRecca
Copy link
Contributor

HanabishiRecca commented May 16, 2024

So is state “completed” the same as “completed” for these 2 panes? Or should they be shown independently?

No. The status column shows only 1 "most relevant" status. But torrents generally have multiple statuses.
As you can see, seeding torrent could also show up under resumed, active, inactive, stalled etc. filters.

@HanabishiRecca
Copy link
Contributor

HanabishiRecca commented May 16, 2024

If you are interested in technical details of how the most relevant status is determined, see here.

Btw, internally it's called "State". Maybe renaming it in the UI to make a distinction between the filters and the column could be a good idea.

@janusn
Copy link
Author

janusn commented May 17, 2024

Thanks for your explanation. I understand "completed" is just a meta-state now. However, it is confusing 2 similar but different meta-states share a single icon and a single wording.

The screencap below illustrates the inconsistency. The elements enclosed in different colored circles carry different meanings.
Screenshot 2024-05-17 at 13 37 23

@janusn janusn changed the title Seeding torrents are considered as completed. The Completed torrents pane includes torrents that are seeding? May 21, 2024
@xavier2k6
Copy link
Member

Related: #17869

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants