Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest code on Github breaks show speed in the Title bar #20843

Closed
dacorsa opened this issue May 14, 2024 · 9 comments · Fixed by #20847
Closed

Latest code on Github breaks show speed in the Title bar #20843

dacorsa opened this issue May 14, 2024 · 9 comments · Fixed by #20847
Assignees
@glassez
Labels
Confirmed bug An issue confirmed by project team to be considered as a bug
Milestone
5.0

Comments

@dacorsa
Copy link

dacorsa commented May 14, 2024

qBittorrent & operating system versions

latest qbittorrent on ubuntu, qt 4.5, latest libtorrent code

What is the problem?

immagine

speed is always 0:0

Steps to reproduce

compile latest code of qbittorrent and libtorrent available on github

Additional context

No response

Log(s) & preferences file(s)

No response
@xavier2k6
Copy link
Member

qt 4.5

Are you sure about that??

@xavier2k6 xavier2k6 added the Waiting info Waiting for participants to supply more info/fulfill template requirements label May 14, 2024
@xavier2k6
Copy link
Member

xavier2k6 commented May 14, 2024 •
edited

In any case, yes you are correct the displayed speed in title bar remains at 0

Screenshot 2024-05-14 162001

@xavier2k6 xavier2k6 added Confirmed bug An issue confirmed by project team to be considered as a bug and removed Waiting info Waiting for participants to supply more info/fulfill template requirements labels May 14, 2024
@dacorsa
Copy link
Author

dacorsa commented May 14, 2024

qt 4.5

Are you sure about that??

excuse me 6.5

@glassez
Copy link
Member

glassez commented May 14, 2024

Well, it is a regression of #20757. I found mistakes and will fix them ASAP.

@glassez glassez self-assigned this May 14, 2024
@glassez glassez added this to the 5.0 milestone May 14, 2024
@xavier2k6
Copy link
Member

xavier2k6 commented May 14, 2024 •
edited

@glassez the tooltip over tray icon stays at 0 too.

Screenshot 2024-05-14 165942

@glassez glassez mentioned this issue May 15, 2024
Merged
@glassez
Copy link
Member

glassez commented May 15, 2024

Could you test #20847?

@dacorsa
Copy link
Author

dacorsa commented May 15, 2024

I have try to compile now and not works:
HEAD ora si trova a 4d8713c WebAPI: Add a way to download .torrent file using search plugin

@glassez
Copy link
Member

glassez commented May 15, 2024

I have try to compile now and not works:
HEAD ora si trova a 4d8713c WebAPI: Add a way to download .torrent file using search plugin

#20847 isn't merged into master.

@xavier2k6
Copy link
Member

@glassez #20847 Fix confirmed. 👍

Screenshot 2024-05-15 084856

glassez added a commit that referenced this issue May 16, 2024
@glassez
Don't hide member variables when storing current speeds
fb796ec 
PR #20847.
Closes #20843.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glassez glassez

Labels
Confirmed bug An issue confirmed by project team to be considered as a bug
Projects
None yet
Milestone
5.0
Development

Successfully merging a pull request may close this issue.

Don't hide member variables when storing current speeds glassez/qBittorrent
3 participants
@glassez @dacorsa @xavier2k6