Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External script with keybinding #113

Open
Monirzadeh opened this issue Jun 28, 2022 · 5 comments
Open

External script with keybinding #113

Monirzadeh opened this issue Jun 28, 2022 · 5 comments
Labels
feature Feature request or related

Comments

@Monirzadeh
Copy link

Is your feature request related to a problem? Please describe.
For control, some aspect of aria2p need to change config with scripts like this issue #112. It is hard or complicated to implement into aria2p.

Describe the solution you'd like
run external (bash or python) scripts with keybinding can solve this problem and expand functionality of aria2p.
For example, we can run a bash script with key binding that ask speed limit, then change some value in aria2c and restart server.

@Monirzadeh Monirzadeh added the feature Feature request or related label Jun 28, 2022
@pawamoy
Copy link
Owner

pawamoy commented Jun 28, 2022

I'm not sure to understand what your feature request is. aria2p already provides programmatic ways to modify options within the running aria2 server. See for example https://pawamoy.github.io/aria2p/reference/api/#aria2p.api.API.set_global_options and set_options just below it.

Are you asking for specific keybindings within the TUI to change these options? Or some kind of TUI menu?

@Monirzadeh
Copy link
Author

Monirzadeh commented Jun 28, 2022

I want to define keybinding in TUI can run a costume script.
This custom script can show specific menu inside aria2p or change multi variable same time.
In your documentation, aria2c options to create the download with I don't want to create new download with option.
Usually I want to change specific configuration in aria2c and restart server.
Or aria2p get specific data from selected item in TUI that I can use them for other modification in my script.

Another example, I want to open a specific download in my file manager. If I have selected item (in TUI) destination and can run a custom command in bash with key o that easily call my file manager with that destination.
No need of this feature inside aria2p

@pawamoy
Copy link
Owner

pawamoy commented Aug 17, 2022

I'm waiting for the CSS branch of Textual to be released. Then I'll be able to rewrite the TUI with Textual and hopefully it will make it much more easier to implement such features. PRs welcome in the mean time 🙂

@Bellavene
Copy link

I was asking about it too here
#109

@pawamoy
Copy link
Owner

pawamoy commented Sep 13, 2023

Textual can be used now to re-implement the TUI with it. Happy to review PRs, otherwise I'll get to it when I need to have some fun 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request or related
Projects
None yet
Development

No branches or pull requests

3 participants