Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux 下 cmake 编译错误,Lua 源文件目录位置未更新,缺少Qt5WebSockets #152

Open
zerobikappa opened this issue Apr 17, 2024 · 3 comments

Comments

@zerobikappa
Copy link
Contributor

zerobikappa commented Apr 17, 2024

(1)

add_subdirectory(Script/lua)

需要改为:

add_subdirectory(Extension/Lua)

(2)

find_package(Qt5 COMPONENTS Widgets Core Gui Network Concurrent Sql Svg REQUIRED)

find_package(Qt5 COMPONENTS DBus REQUIRED)

以上其中一处需要加上WebSockets

find_package(Qt5 COMPONENTS ... WebSockets REQUIRED)

(3)

KikoPlay/CMakeLists.txt

Lines 72 to 83 in d0437da

target_link_libraries(${PROJECT_NAME}
PRIVATE
ZLIB::ZLIB
Qt::Core
Qt::Gui
Qt::Widgets
Qt::Network
Qt::Concurrent
Qt::Sql
Qt::Svg
myLua53
)

KikoPlay/CMakeLists.txt

Lines 114 to 118 in d0437da

target_link_libraries(${PROJECT_NAME}
PRIVATE
${mpv_LIBRARIES}
Qt5::DBus
)

以上其中一处需要加上Qt::WebSockets

target_link_libraries(${PROJECT_NAME} 
PRIVATE 
    ...
    ...
    Qt::WebSockets
)

修改之后不需要用vcpkg,直接编译就能通过。
不过对于(2)和(3),由于我只使用 Archlinux 所以不确定其他发行版是不是有同样问题,也不确定 windows 是不是也有同样的问题。不确定是否有必要修改,也不确定应该把修改放哪个位置,所以没有提交PR。

@madoka773
Copy link
Contributor

aur不能用吗?

https://github.com/flathub/io.github.KikoPlayProject.KikoPlay

或者可以参考flatpak

@zerobikappa
Copy link
Contributor Author

zerobikappa commented Apr 17, 2024

@madoka773 aur就是我在维护,用的是qmake编译所以没这问题,最近想试一下用cmake编译然后就发现CMakeLists.txt文件有这个问题。

@Protostars
Copy link
Collaborator

可以提个mr,cmake相关配置我没有维护

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants